Fix failure to set imagePullSecrets for user-placeholder pods (scheduling.userPlaceholder.image config added) #2293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated summary by Erik
prePuller.pause.image.name|tag
was used to set the user-placeholder pods image, but the user-placeholder pods didn't make use of theprePuller.pause.image.pullPolicy|pullSecrets
or any other config to set imagePullPolicy or imagePullSecrets. With this PR the dedicated optionscheduling.userPlaceholer.image
and respective fields are added and respected for the user-placeholder pods.Original PR summary
prePuller.pause.image.pullSecrets
was already defined invalues.yaml
but it was never actually used in the placeholder statefulset template.